-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-4466 Add CSOT #951
base: master
Are you sure you want to change the base?
DOCSP-4466 Add CSOT #951
Conversation
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, thanks for taking this! Some suggestions for clarity and small fixes. I'll be back Jan 7, but Mike says he is available for re-review if you want it back a little sooner. Have a great holiday break!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of comments, but they're all small. great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small things but otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments and fix, great work on this! LGTM :)
Overview | ||
-------- | ||
|
||
When you use {+driver-short+} to perform a server operation, you can also limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you use {+driver-short+} to perform a server operation, you can also limit | |
When you use the {+driver-short+} to perform a server operation, you can also limit |
S: I think we normally put 'the' in front of the the driver name!
specify a **client-side operation timeout (CSOT)**. The timeout applies to all steps | ||
needed to complete the operation, including server selection, connection | ||
checkout, serialization, and server-side execution. When the timeout expires, | ||
{+driver-short+} raises a timeout exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{+driver-short+} raises a timeout exception. | |
the {+driver-short+} raises a timeout exception. |
the
~~~~~~~~~~~~~~~~~~~ | ||
|
||
When you specify a ``timeoutMS`` option, the driver applies the timeout | ||
according to the same inheritance behaviors as other {+driver-short+} options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to the same inheritance behaviors as other {+driver-short+} options. | |
according to the same inheritance behaviors as the other {+driver-short+} options. |
S: Could put 'the' here as well, since you're talking about a specific set of options mentioned previously
``getMore()`` method must finish within the limit specified by the ``timeoutMS`` | ||
option. If they do not, the system throws a timeout error. | ||
|
||
When you close a cursor by calling the ``toArray()``or ``close()`` method, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you close a cursor by calling the ``toArray()``or ``close()`` method, the | |
When you close a cursor by calling the ``toArray()`` or ``close()`` method, the |
I: The space fixes the formatting on the page!
As shown in the following example, the cursor continues to fetch new documents | ||
as they are added to a collection, and then times out if it takes longer than 10 | ||
seconds to retrieve documents: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As shown in the following example, the cursor continues to fetch new documents | |
as they are added to a collection, and then times out if it takes longer than 10 | |
seconds to retrieve documents: | |
As shown in the following example, the cursor continues to fetch new documents | |
as they are added to a collection and times out if it takes longer than 10 | |
seconds to retrieve documents: |
S: Don't think that second clause is independent, so I removed the comma and 'then'. Could also separate into two sentences.
Style Guide on 'then' : https://www.mongodb.com/docs/meta/style-guide/terminology/alphabetical-terms/#t
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44666
Staging - https://deploy-preview-951--docs-node.netlify.app/fundamentals/connection/csot/
Self-Review Checklist