Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34101-create-bulk-operations-page #948

Merged

Conversation

gmiller-mdb
Copy link
Collaborator

@gmiller-mdb gmiller-mdb commented Dec 11, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34101
Staging - https://deploy-preview-948--docs-node.netlify.app/fundamentals/crud/write-operations/bulk/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 4f6ad46
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/677c5457a0b96700082c8ddf
😎 Deploy Preview https://deploy-preview-948--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ✨ a few formatting updates and style guide suggestions in the comments.

source/fundamentals/crud/write-operations.txt Outdated Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
source/code-snippets/crud/bulk.js Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
source/code-snippets/crud/bulk.js Outdated Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
source/fundamentals/crud/write-operations/bulk.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small comment!

source/code-snippets/crud/bulk.js Outdated Show resolved Hide resolved
@W-A-James W-A-James self-requested a review January 6, 2025 19:54
Copy link

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿

Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmiller-mdb gmiller-mdb merged commit 05844f2 into mongodb:master Jan 7, 2025
4 of 5 checks passed
gmiller-mdb added a commit that referenced this pull request Jan 10, 2025
* DOCSP-34101-create-bulk-operations-page

* fleshed out page entierly

* fix errors add toctree

* toctree

* bulk page

* real paths

* test

* added api links

* fixed link and syntax

* syntax

* fix link

* feedback

* changed type

* fix indent

* feedback

(cherry picked from commit 05844f2)
gmiller-mdb added a commit that referenced this pull request Jan 10, 2025
* DOCSP-34101-create-bulk-operations-page

* fleshed out page entierly

* fix errors add toctree

* toctree

* bulk page

* real paths

* test

* added api links

* fixed link and syntax

* syntax

* fix link

* feedback

* changed type

* fix indent

* feedback

(cherry picked from commit 05844f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants