Configuration+Build Changes and More Documentation for Obtaining the Library #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Dec 19, 2024
| # Miscellaneous system init | ||
| INIT: | ||
| FUNCTION | ||
| COPY --chmod=755 tools/__install /usr/local/bin/__install |
There was a problem hiding this comment.
tools/__install may be missing. Running earthly -a +build-debian/pkg deb-pkg resulted in:
+build-debian *failed* | COPY tools/__install /usr/local/bin/__install
+build-debian *failed* | failed: failed to walk /tmp/buildkit-mount4293366862/tools: lstat /tmp/buildkit-mount4293366862/tools: no such file or directory
| By default, the |amongoc| CMake package will attempt to import dependencies | ||
| using :cmake:command:`find_dependency <command:find_dependency>`. This import | ||
| can be disabled by changing :cmake:variable:`AMONGOC_FIND_DEPENDENCIES`. | ||
|
|
||
| **If you build** |amongoc| using vcpkg_ (the default) it is highly recommended | ||
| to use vcpkg in your own project to install |amongoc|'s dependencies, as it is |
There was a problem hiding this comment.
Consider adding a sample project with instructions to install amongoc and building a consumer with vcpkg. Example: https://gist.github.com/kevinAlbs/636fb109747ee4faba16def81c578a93 That may help give a fast-path to testing the driver.
There was a problem hiding this comment.
I'll look into this in subsequent changes.
kevinAlbs
reviewed
Dec 30, 2024
Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce tweaks to the build process, as well as documentation changes that clarify the behavior regarding dependencies. The following changes are made:
FetchContentrather than with vcpkg. These components do not require any link-time dependencies in any projects that importamongoc.vcpkg. This verifies that we can build on up-to-date platforms.