Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support handling multiple PIDs in killport #509

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Sep 30, 2024

Addresses the following possible error on certain distros (e.g. Ubuntu 18.04) due to lsof returning more than one PID:

start-orchestration.sh: line 76: kill: 4850
5401: arguments must be process or job IDs

Extends all find-and-kill-PID routines to support the possibility of multiple PIDs being returned by the PID query command.

@eramongodb eramongodb self-assigned this Sep 30, 2024
@eramongodb eramongodb marked this pull request as ready for review September 30, 2024 18:00
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eramongodb eramongodb merged commit aeebb86 into mongodb-labs:master Sep 30, 2024
55 of 56 checks passed
@eramongodb eramongodb deleted the det-killport branch September 30, 2024 18:06
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants