Address shellcheck warnings (#495)

.evergreen/atlas/atlas-utils.sh

@@ -21,7 +21,7 @@ create_deployment ()
 
   # Ensure that all variables required to run the test are set, otherwise throw
   # an error.
-  for VARNAME in ${VARLIST[*]}; do
+  for VARNAME in "${VARLIST[@]}"; do
   [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
   done
 
@@ -54,7 +54,7 @@ check_deployment ()
 
   # Ensure that all variables required to run the test are set, otherwise throw
   # an error.
-  for VARNAME in ${VARLIST[*]}; do
+  for VARNAME in "${VARLIST[@]}"; do
   [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
   done
 

.evergreen/atlas/setup-atlas-cluster.sh

@@ -37,6 +37,7 @@ fi
 
 # Backwards compatibility: map old names to new names.
 if [ -n "${LAMBDA_STACK_NAME:-}" ]; then
+  # shellcheck disable=SC2034
   CLUSTER_PREFIX=$LAMBDA_STACK_NAME
 fi
 if [ -n "${DRIVERS_ATLAS_LAMBDA_USER:-}" ]; then
@@ -57,7 +58,7 @@ CLUSTER_PREFIX
 
 # Ensure that all variables required to run the test are set, otherwise throw
 # an error.
-for VARNAME in ${VARLIST[*]}; do
+for VARNAME in "${VARLIST[@]}"; do
 [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
 done
 
@@ -71,7 +72,7 @@ done
 export VERSION="${MONGODB_VERSION:-6.0}"
 
 # Set the create cluster configuration.
-export DEPLOYMENT_DATA=$(cat <<EOF
+DEPLOYMENT_DATA=$(cat <<EOF
 {
   "autoScaling" : {
     "autoIndexingEnabled" : false,
@@ -116,6 +117,7 @@ export DEPLOYMENT_DATA=$(cat <<EOF
 }
 EOF
 )
+export DEPLOYMENT_DATA
 
 export ATLAS_PUBLIC_API_KEY=$DRIVERS_ATLAS_PUBLIC_API_KEY
 export ATLAS_PRIVATE_API_KEY=$DRIVERS_ATLAS_PRIVATE_API_KEY

.evergreen/atlas/setup-variables.sh

@@ -12,9 +12,12 @@ set -eu
 
 # The base Atlas API url. We use the API directly as the CLI does not yet
 # support testing cluster outages.
+# shellcheck disable=SC2034
 DEFAULT_URL="https://cloud.mongodb.com/api/atlas/v1.0"
+# shellcheck disable=SC2034
 ATLAS_BASE_URL="${DRIVERS_ATLAS_BASE_URL:-$DEFAULT_URL}"
 
 # Create a unique atlas project name.
 suffix=$(node -e "process.stdout.write(require('crypto').randomBytes(32).toString('hex').slice(0,16))")
+# shellcheck disable=SC2034
 CLUSTER_NAME="${CLUSTER_PREFIX}-${suffix}"

.evergreen/atlas/teardown-atlas-cluster.sh

@@ -26,7 +26,7 @@ fi
 
 # Ensure that all variables required to run the test are set, otherwise throw
 # an error.
-for VARNAME in ${VARLIST[*]}; do
+for VARNAME in "${VARLIST[@]}"; do
 [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
 done
 

.evergreen/auth_aws/lib/ecs_hosted_test.sh

@@ -4,7 +4,7 @@ set -ex
 
 # The environment variable is always set during interactive logins
 # But for non-interactive logs, ~/.bashrc does not appear to be read on Ubuntu but it works on Fedora
-[[ -z "${AWS_CONTAINER_CREDENTIALS_RELATIVE_URI}" ]] && export $(strings /proc/1/environ | grep AWS_CONTAINER_CREDENTIALS_RELATIVE_URI)
+[[ -z "${AWS_CONTAINER_CREDENTIALS_RELATIVE_URI}" ]] && export "$(strings /proc/1/environ | grep AWS_CONTAINER_CREDENTIALS_RELATIVE_URI)"
 
 env
 

.evergreen/auth_oidc/azure/create-and-setup-vm.sh

@@ -39,6 +39,7 @@ pushd ..
 . ./activate-authoidcvenv.sh
 popd
 python ./handle_secrets.py
+# shellcheck source=env.sh
 source $AZUREOIDC_ENVPATH
 
 # Create VM.

.evergreen/auth_oidc/azure/run-driver-test.sh

@@ -26,6 +26,7 @@ export AZUREKMS_PRIVATEKEYPATH=$SCRIPT_DIR/keyfile
 
 # Set up the remote driver checkout.
 DRIVER_TARFILE_BASE=$(basename ${AZUREOIDC_DRIVERS_TAR_FILE})
+# shellcheck disable=SC2088
 AZUREKMS_SRC=${AZUREOIDC_DRIVERS_TAR_FILE} \
 AZUREKMS_DST="~/" \
   $SCRIPT_DIR/../../csfle/azurekms/copy-file.sh

.evergreen/auth_oidc/azure_func/invoke.sh

@@ -24,7 +24,7 @@ if [ -z "$MONGODB_URI" ]; then
 fi
 
 CODE=$(az functionapp function keys list -g $AZUREOIDC_FUNC_RESOURCE_GROUP -n $FUNC_APP_NAME --function-name $FUNC_NAME | jq -r '.default')
-URL=https://$FUNC_APP_NAME.azurewebsites.net/api/$FUNC_NAME?code=$CODE
+URL="https://$FUNC_APP_NAME.azurewebsites.net/api/$FUNC_NAME?code=$CODE"
 DATA="{\"MONGODB_URI\": \"$MONGODB_URI\" }"
 
 curl -i \

.evergreen/auth_oidc/azure_func/run-driver-test.sh

@@ -17,7 +17,7 @@ MONGODB_URI
 
 # Ensure that all variables required to run the test are set, otherwise throw
 # an error.
-for VARNAME in ${VARLIST[*]}; do
+for VARNAME in "${VARLIST[@]}"; do
   [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
 done
 

.evergreen/auth_oidc/azure_func/setup.sh

@@ -35,7 +35,7 @@ DEPLOYMENT_NAME="$RANDOM-DRIVERGCP"
 echo "export CLUSTER_NAME=$DEPLOYMENT_NAME" >> "secrets-export.sh"
 
 # Set the create cluster configuration.
-export DEPLOYMENT_DATA=$(cat <<EOF
+DEPLOYMENT_DATA=$(cat <<EOF
 {
   "autoScaling" : {
     "autoIndexingEnabled" : false,
@@ -80,6 +80,7 @@ export DEPLOYMENT_DATA=$(cat <<EOF
 }
 EOF
 )
+export DEPLOYMENT_DATA
 
 export ATLAS_PUBLIC_API_KEY=$OIDC_ATLAS_PUBLIC_API_KEY
 export ATLAS_PRIVATE_API_KEY=$OIDC_ATLAS_PRIVATE_API_KEY
@@ -102,7 +103,8 @@ fi
 
 ########################
 # Wait for the Atlas Cluster
-export MONGODB_URI=$(check_deployment)
+MONGODB_URI=$(check_deployment)
+export MONGODB_URI
 echo "export MONGODB_URI=$MONGODB_URI" >> ./secrets-export.sh
 
 popd

.evergreen/auth_oidc/gcp/setup-instance.sh

@@ -5,14 +5,18 @@ set -o errexit # Exit on first command error.
 SCRIPT_DIR=$(dirname ${BASH_SOURCE[0]})
 . $SCRIPT_DIR/../../handle-paths.sh
 
-if [ -z "$GCPKMS_GCLOUD" -o -z "$GCPKMS_PROJECT" -o -z "$GCPKMS_ZONE" -o -z "$GCPKMS_INSTANCENAME" ]; then
-    echo "Please set the following required environment variables"
-    echo " GCPKMS_GCLOUD to the path of the gcloud binary"
-    echo " GCPKMS_PROJECT to the GCP project"
-    echo " GCPKMS_ZONE to the GCP zone"
-    echo " GCPKMS_INSTANCENAME to the GCE instance name"
-    exit 1
-fi
+VARLIST=(
+GCPKMS_GCLOUD
+GCPKMS_PROJECT
+GCPKMS_ZONE
+GCPKMS_INSTANCENAME
+)
+
+# Ensure that all variables required to run the test are set, otherwise throw
+# an error.
+for VARNAME in "${VARLIST[@]}"; do
+  [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
+done
 
 echo "Copying setup-gce-instance.sh to GCE instance ($GCPKMS_INSTANCENAME) ... begin"
 # Copy files to test. Use "-p" to preserve execute mode.

.evergreen/auth_oidc/gcp/setup.sh

@@ -22,7 +22,7 @@ DEPLOYMENT_NAME="$RANDOM-DRIVERGCP"
 echo "export CLUSTER_NAME=$DEPLOYMENT_NAME" >> "$DRIVERS_TOOLS/.evergreen/atlas/secrets-export.sh"
 
 # Set the create cluster configuration.
-export DEPLOYMENT_DATA=$(cat <<EOF
+DEPLOYMENT_DATA=$(cat <<EOF
 {
   "autoScaling" : {
     "autoIndexingEnabled" : false,
@@ -67,6 +67,7 @@ export DEPLOYMENT_DATA=$(cat <<EOF
 }
 EOF
 )
+export DEPLOYMENT_DATA
 
 export ATLAS_PUBLIC_API_KEY=$OIDC_ATLAS_PUBLIC_API_KEY
 export ATLAS_PRIVATE_API_KEY=$OIDC_ATLAS_PRIVATE_API_KEY

.evergreen/auth_oidc/k8s/remote-scripts/run-self-test.sh

@@ -9,7 +9,7 @@ pip install -U -q pip pymongo
 echo "Installing dependencies ... end"
 
 # Run the Python Driver Self Test
-SCRIPT_DIR=$(realpath $(dirname ${BASH_SOURCE[0]}))
+SCRIPT_DIR=$(realpath "$(dirname ${BASH_SOURCE[0]})")
 pushd $SCRIPT_DIR
 source secrets-export.sh
 python test.py

.evergreen/auth_oidc/k8s/remote-scripts/start-server.sh

@@ -2,7 +2,7 @@
 set -eu
 
 # Start an OIDC-enabled server.
-SCRIPT_DIR=$(realpath $(dirname ${BASH_SOURCE[0]}))
+SCRIPT_DIR=$(realpath "$(dirname ${BASH_SOURCE[0]})")
 cd $SCRIPT_DIR
 source secrets-export.sh
 

.evergreen/auth_oidc/k8s/run-driver-test.sh

@@ -12,6 +12,12 @@ K8S_DRIVERS_TAR_FILE
 K8S_TEST_CMD
 )
 
+# Ensure that all variables required to run the test are set, otherwise throw
+# an error.
+for VARNAME in "${VARLIST[@]}"; do
+  [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
+done
+
 source secrets-export.sh
 source $K8S_VARIANT_DIR/secrets-export.sh
 

.evergreen/auth_oidc/k8s/setup.sh

@@ -37,7 +37,7 @@ DEPLOYMENT_NAME="$RANDOM-DRIVER-K8S"
 echo "export CLUSTER_NAME=$DEPLOYMENT_NAME" >> "$DRIVERS_TOOLS/.evergreen/atlas/secrets-export.sh"
 
 # Set the create cluster configuration.
-export DEPLOYMENT_DATA=$(cat <<EOF
+DEPLOYMENT_DATA=$(cat <<EOF
 {
   "autoScaling" : {
     "autoIndexingEnabled" : false,
@@ -82,6 +82,7 @@ export DEPLOYMENT_DATA=$(cat <<EOF
 }
 EOF
 )
+export DEPLOYMENT_DATA
 
 export ATLAS_PUBLIC_API_KEY=$OIDC_ATLAS_PUBLIC_API_KEY
 export ATLAS_PRIVATE_API_KEY=$OIDC_ATLAS_PRIVATE_API_KEY

.evergreen/auth_oidc/oidc_get_tokens.sh

@@ -7,11 +7,12 @@ SCRIPT_DIR=$(dirname ${BASH_SOURCE[0]})
 . $SCRIPT_DIR/../handle-paths.sh
 
 if [ -z "${OIDC_TOKEN_DIR:-}" ]; then
-    export OIDC_TOKEN_DIR=/tmp/tokens
+    OIDC_TOKEN_DIR=/tmp/tokens
 fi
 if [ "Windows_NT" = "${OS:-}" ]; then
-    export OIDC_TOKEN_DIR=$(cygpath -m $OIDC_TOKEN_DIR)
+    OIDC_TOKEN_DIR=$(cygpath -m $OIDC_TOKEN_DIR)
 fi
+export OIDC_TOKEN_DIR
 mkdir -p $OIDC_TOKEN_DIR
 
 pushd $SCRIPT_DIR

.evergreen/auth_oidc/setup.sh

@@ -41,7 +41,7 @@ else
   echo "export CLUSTER_NAME=$DEPLOYMENT_NAME" >> "secrets-export.sh"
 
   # Set the create cluster configuration.
-  export DEPLOYMENT_DATA=$(cat <<EOF
+  DEPLOYMENT_DATA=$(cat <<EOF
 {
   "autoScaling" : {
     "autoIndexingEnabled" : false,
@@ -86,6 +86,7 @@ else
 }
 EOF
   )
+  export DEPLOYMENT_DATA
 
   export ATLAS_PUBLIC_API_KEY=$OIDC_ATLAS_PUBLIC_API_KEY
   export ATLAS_PRIVATE_API_KEY=$OIDC_ATLAS_PRIVATE_API_KEY

.evergreen/aws_lambda/run-deployed-lambda-aws-tests.sh

@@ -34,12 +34,13 @@ SECRETS_FILE=$SCRIPT_DIR/../atlas/secrets-export.sh
 
 if [ -f $SECRETS_FILE ]; then
   echo "Sourcing secrets"
+  # shellcheck source=../atlas/secrets-export.sh
   source $SECRETS_FILE
 fi
 
 # Ensure that all variables required to run the test are set, otherwise throw
 # an error.
-for VARNAME in ${VARLIST[*]}; do
+for VARNAME in "${VARLIST[@]}"; do
 [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
 done
 

.evergreen/compile-unix.sh

@@ -49,6 +49,7 @@ case "$OS" in
       # Make linux builds a tad faster by parallelise the build
       cpus=$(grep -c '^processor' /proc/cpuinfo)
       MAKEFLAGS="-j${cpus}"
+      echo $MAKEFLAGS $TAR
    ;;
 
    sunos)

.evergreen/compile-windows.sh

@@ -37,7 +37,8 @@ case "$CC" in
    ;;
 esac
 
-export PATH=$PATH:`pwd`/tests:`pwd`/Debug:`pwd`/src/libbson/Debug
+PATH=$PATH:`pwd`/tests:`pwd`/Debug:`pwd`/src/libbson/Debug
+export PATH
 CMAKE="/cygdrive/c/cmake/bin/cmake"
 INSTALL_DIR="C:/install-dir"
 

.evergreen/csfle/await-servers.sh

@@ -9,7 +9,7 @@ pushd $SCRIPT_DIR
 # Wait until the pids file has been created.
 echo "Waiting for servers to start..."
 await_pidfile() {
-    for i in $(seq 300); do
+    for _ in $(seq 300); do
         if [ -f ./kmip_pids.pid ]; then
             return 0
         fi
@@ -25,7 +25,7 @@ echo "Waiting for servers to start...done"
  # Ensure servers are running.
 await_server() {
     echo "Waiting on $1 server on port $2"
-    for i in $(seq 10); do
+    for _ in $(seq 10); do
         # Exit code 7: "Failed to connect to host".
         if curl -s "localhost:$2"; test $? -ne 7; then
             echo "Waiting on $1 server on port $2...done"

.evergreen/csfle/azurekms/create-and-setup-vm.sh

@@ -40,7 +40,7 @@ AZUREKMS_SCOPE
 
 # Ensure that all variables required to run the test are set, otherwise throw
 # an error.
-for VARNAME in ${VARLIST[*]}; do
+for VARNAME in "${VARLIST[@]}"; do
 [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
 done
 

.evergreen/csfle/azurekms/create-vm.sh

@@ -39,7 +39,7 @@ az vm create \
     --assign-identity $AZUREKMS_IDENTITY \
     >/dev/null
 
-if [ $(uname -s) = "Darwin" ]; then
+if [ "$(uname -s)" = "Darwin" ]; then
     SHUTDOWN_TIME=$(date -u -v+1H +"%H%M")
 else
     SHUTDOWN_TIME=$(date -u -d "$(date) + 1 hours" +"%H%M")

.evergreen/csfle/azurekms/login.sh

@@ -3,15 +3,17 @@ set -o errexit
 set -o pipefail
 set -o nounset
 
-if [ -z "$AZUREKMS_CLIENTID" -o \
-     -z "$AZUREKMS_SECRET" -o \
-     -z "$AZUREKMS_TENANTID" ]; then
-    echo "Please set the following required environment variables"
-    echo " AZUREKMS_CLIENTID"
-    echo " AZUREKMS_SECRET"
-    echo " AZUREKMS_TENANTID"
-    exit 1
-fi
+VARLIST=(
+AZUREKMS_CLIENTID
+AZUREKMS_SECRET
+AZUREKMS_TENANTID
+)
+
+# Ensure that all variables required to run the test are set, otherwise throw
+# an error.
+for VARNAME in "${VARLIST[@]}"; do
+  [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
+done
 
 # Check for Azure Command-Line Interface (`az`) version 2.25.0 or newer.
 if ! command -v az &> /dev/null; then

.evergreen/csfle/azurekms/run-command.sh

@@ -3,17 +3,18 @@ set -o errexit
 set -o pipefail
 set -o nounset
 
-if [ -z "$AZUREKMS_RESOURCEGROUP" -o \
-     -z "$AZUREKMS_VMNAME" -o \
-     -z "$AZUREKMS_PRIVATEKEYPATH" -o \
-     -z "$AZUREKMS_CMD" ]; then
-    echo "Please set the following required environment variables"
-    echo " AZUREKMS_RESOURCEGROUP"
-    echo " AZUREKMS_VMNAME"
-    echo " AZUREKMS_PRIVATEKEYPATH"
-    echo " AZUREKMS_CMD"
-    exit 1
-fi
+VARLIST=(
+AZUREKMS_RESOURCEGROUP
+AZUREKMS_VMNAME
+AZUREKMS_PRIVATEKEYPATH
+AZUREKMS_CMD
+)
+
+# Ensure that all variables required to run the test are set, otherwise throw
+# an error.
+for VARNAME in "${VARLIST[@]}"; do
+  [[ -z "${!VARNAME:-}" ]] && echo "ERROR: $VARNAME not set" && exit 1;
+done
 
 echo "Running '$AZUREKMS_CMD' on Azure Virtual Machine ... begin"
 IP=$(az vm show --show-details --resource-group $AZUREKMS_RESOURCEGROUP --name $AZUREKMS_VMNAME --query publicIps -o tsv)