feat(chat): automatically pick the collection if there exists only one in the database VSCODE-610 #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
changed the title
gagik
changed the title
gagik
changed the title
gagik
commented
Nov 1, 2024
| log.error('Unable to fetch collections:', error); | ||
|
|
||
| // Users can always do this manually when asked to provide a collection name. | ||
| return; |
There was a problem hiding this comment.
I am not sure what "this" is referring to here so I am not sure if there's something more to this but the behavior should be largely same with _getCollections, I just didn't transfer the comment over as I didn't understand it.
There was a problem hiding this comment.
The comment here was alluding to if we can't fetch the collection names then a user can still input it by typing. It could definitely have been a bit more descriptive. I think that's why we're silently returning here instead of throwing an error.
gagik
commented
Nov 1, 2024
| const chatId = ChatMetadataStore.getChatIdFromHistoryOrNewChatId( | ||
| context.history | ||
| ); | ||
| this._chatMetadataStore.setChatMetadata(chatId, { |
There was a problem hiding this comment.
Does this make sense to do? If I understand right this means this will effectively cache it but I haven't tested it yet, will soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In interest of keeping PRs for VSCODE-610 easier to review since it mentions 3-4 new behaviors, I am splitting them into different parts. This handles the case where there is only 1 collection in the database, so we'd want to pick that instead of prompting the user.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes