Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtest: add submodule #9715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gtest: add submodule #9715

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Jan 17, 2025 •
edited
Loading

Replaces #9271.

  • GTest is checked out to v1.15.2.
  • Requires CMake 3.13 or higher.

See discussion on #9272 for context.

@tobtoht tobtoht marked this pull request as draft January 17, 2025 22:23
@tobtoht tobtoht mentioned this pull request Jan 17, 2025
Open
@jeffro256
Copy link
Contributor

Btw, I approve of the general approach, though.

@0xFFFC0000
Copy link
Collaborator

Other than minor issue raised by @jeffro256 , I support / approve this PR.

@0xFFFC0000
Copy link
Collaborator

@tobtoht please remove “Draft” if this PR is “Pending Review”.

@tobtoht tobtoht mentioned this pull request Jan 19, 2025
Closed
@tobtoht tobtoht marked this pull request as ready for review January 19, 2025 11:32
@tobtoht tobtoht mentioned this pull request Jan 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

@iamamyth iamamyth iamamyth approved these changes

@jeffro256 jeffro256 jeffro256 approved these changes

Assignees
No one assigned
Labels
pending review tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobtoht @jeffro256 @0xFFFC0000 @iamamyth