Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: always pass --with-pic to autoconf builds #9671

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

depends: always pass --with-pic to autoconf builds #9671

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Jan 3, 2025 •
edited
Loading

Merge after #9643.

0xFFFC0000
0xFFFC0000 reviewed Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Question. Do we need pic for everything? Usually pic codeis more bloated.

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 7, 2025

My understanding is that this flag instructs libtool to prefer pic objects, which may or may not fix a build issue. Setting the flag everywhere can't hurt.

See also the libtool documentation (Note: --with-pic was renamed to --enable-pic)

Precision Independent Code is a security feature. Our release binaries are already PIE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 left review comments

Assignees
No one assigned
Labels
build system pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobtoht @0xFFFC0000 @selsta