pattern for disease caused by one of multiple genes #8173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
cmungall
requested changes
Oct 14, 2024
There was a problem hiding this comment.
This isn't the correct way to do multivalued fields in dosdp. These were introduced here INCATools/dead_simple_owl_design_patterns#71. I will see if I can find some docs on how to use them. @matentzn may be able to help.
Note we can't represent unions in expressions, obo format, and union reasoning in Elk is incomplete
But why do we even need a logical definition here? I would focus on documenting the pattern, and only do logical definitions for really simple clear cases.
How often do we expect this? Surely in most cases the grouping will correspond to a union of gene-specific diseases (here a disjoint union is fine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8082
@cmungall Could you please review this?
Is this what you had in mind? I know using "or" in logical definition is not great, but it is what would work for this (I think).
That being said, the logical definition using "or" in mondo-edit.obo looks unlike anything else in OBO. This makes me question whether what I did is correct. Screenshots below for convenience. Thank you!