Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ORDO xref to cornea plana #7590

Merged
merged 2 commits into from
Apr 16, 2024
Merged

add ORDO xref to cornea plana #7590

merged 2 commits into from
Apr 16, 2024

Conversation

nicolevasilevsky
Copy link
Member

@nicolevasilevsky nicolevasilevsky commented Apr 12, 2024

this is a bit of an unusual case:

  • we obsoleted congenital corena plana but Gioconda asked that it be added back as an xref for cornea plana, so I added the ORDO xref and pointed to this term on the obsoleted term
  • close Congenital cornea plana #7573

this is a bit of an unusual case:
- we obsoleted congenital corena plana but Gioconda asked that it be added back as an xref for cornea plana, so I added the ORDO xref and pointed to this term on the obsoleted term
close #7573
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolevasilevsky could you please add the definition from Orphanet? https://www.orpha.net/en/disease/detail/53691?name=53691&mode=orpha
Thank you

@nicolevasilevsky
Copy link
Member Author

done

at some point we'll sync all of these definitions, right? so we won't have to add them manually?

@twhetzel
Copy link
Collaborator

I think there are still general discussions to sync definitions. Is the work in this ticket a good use case/example of this issue?

@nicolevasilevsky
Copy link
Member Author

yes - this is a case where there was no definition and I added the ORDO def

If you would like examples of where I update the definition that comes from ORDO, I can make a note next time I come across one

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sabrinatoro sabrinatoro merged commit 8ebfc84 into master Apr 16, 2024
1 check passed
@sabrinatoro sabrinatoro deleted the issue-7573 branch April 16, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Congenital cornea plana
3 participants