-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for cancer reclassification #7042
Conversation
Addresses #6533
@nicolevasilevsky @cmungall (though Chris has already approved :-) ) |
I updated the logical definition for "hereditary neoplastic syndrome" to be 'inherited disease susceptibility' and ('predisposes towards' some neoplasm) This brought a lot of "cancer susceptibility" into "cancer predisposition" branch, which was requested by ClinGen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me. It will be great to get the expert advice, this is certainly a tricky area.
I updated the logical definition for "hereditary neoplastic syndrome" to be This brought a lot of "cancer susceptibility" into "cancer predisposition" branch, which was requested by ClinGen @cmungall @nicolevasilevsky do you see any reason why it is not a good idea to do so (or why it is wrong to do so)? And I agree, we should ask experts about this! We will definitely run this by the ClinGen team, but we should have a bigger discussion about it... at one point. |
this looks good to me, all the terms that were auto-classified make sense. |
This PR was approved by Chris and Nicole, but the merging is still blocked. I am bypassing the branch protections and merging. |
Addresses #6533