-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slurp pipeline: Initial design #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
force-pushed
the
slurpdraft
branch
4 times, most recently
from
July 28, 2022 21:16
5b87e9b
to
384652c
Compare
joeflack4
reviewed
Aug 3, 2022
joeflack4
reviewed
Aug 3, 2022
joeflack4
force-pushed
the
slurpdraft
branch
2 times, most recently
from
August 3, 2022 21:00
c5e08e0
to
3356948
Compare
joeflack4
reviewed
Aug 3, 2022
joeflack4
force-pushed
the
slurpdraft
branch
3 times, most recently
from
August 3, 2022 21:40
23d49b4
to
e54f171
Compare
joeflack4
reviewed
Aug 3, 2022
joeflack4
reviewed
Aug 3, 2022
joeflack4
reviewed
Aug 4, 2022
joeflack4
reviewed
Aug 4, 2022
joeflack4
reviewed
Aug 4, 2022
joeflack4
force-pushed
the
slurpdraft
branch
2 times, most recently
from
August 5, 2022 01:26
de81b23
to
630d6d8
Compare
joeflack4
force-pushed
the
slurpdraft
branch
2 times, most recently
from
September 30, 2022 02:12
6d4460c
to
04d5379
Compare
joeflack4
reviewed
Sep 30, 2022
joeflack4
reviewed
Sep 30, 2022
joeflack4
force-pushed
the
slurpdraft
branch
from
September 30, 2022 02:26
04d5379
to
3717f78
Compare
joeflack4
reviewed
Sep 30, 2022
joeflack4
force-pushed
the
slurpdraft
branch
from
September 30, 2022 02:34
3717f78
to
59b431f
Compare
matentzn
commented
Sep 30, 2022
joeflack4
force-pushed
the
slurpdraft
branch
3 times, most recently
from
September 30, 2022 18:29
1f3ee92
to
d2eee94
Compare
- Update: Basic pseudo code in Python updated - Update: Makfile: Updating formatting.
- Add: makefile: Missing make goals for dependencies for slurp goal. - Add: Python: CLI - Update: makefile: Slurp goal: (i) named keys/vals for all params, (ii) standardization in file/path params. - Update: Python: Completed script, inspired by initial psuedo code. (WIP) - Add: Makefile: reports/mirror_signature-mondo.tsv: This depends on different prereqs than reports/mirror_signature-%.txv. - Add: Makefile: .db creation command(s). Misc updates - Update: makefile: python-install-dependencies: Now upgrades all dependencies to latest version. - .gitignore: (i) Added .db, (ii) src/ontology/components/*relation-graph* - requirements*.txt: (i) Added semsql, (ii) added curies, (iii) Upgraded various dependencies / transitive dependencies
1. Never depend on a PHONY goal, because they force the whole pipeline to be rebuild - just add them to each goal, installing a few python dependencies that are already installed is fast enough. 2. PHONY goals cannot have wildcard dependencies: https://stackoverflow.com/questions/7887343/makefile-wildcard-static-rule-with-phony 3. Indentation is critical with Make targets, your `# TODO: Temporary debugging:` was wrongly intented to the level of the target name, not the body.
- Delete: `mondo-ingest.Makefile`: (i) `python-install-dependencies` phony target. This has been removed in favor of expediently updating the dependencies in ODK directly. (ii) Removed unused, commented out mondo component target. - Update: `.gitignore`: Simplified to ignoring whole dir `src/ontology/components/*` - Update: Python requirements: Removed `semsql` w/ specific version, due to some recent dependency fixes in OAK. Term exclusions - Update: Rename: reports/term_exclusions.txt -> reports/excluded_terms.txt
- Delete: Initialized a variables for 'all relationships' and 'term parent map', but did a more OAK-reliant refactor and removed these. - Add: Term class - Update: Big refactor to utilize Term class - Add: Slurp output TSV files - Add: utils.py, which includes Term class - Add: New param: max_id Misc - Update: run.sh: This change will allow any Python package updates to be retained. - Add: SPARQL jinja query to get parents. Used by slurp pipeline.
joeflack4
force-pushed
the
slurpdraft
branch
5 times, most recently
from
September 30, 2022 21:56
62b153d
to
fd6f901
Compare
joeflack4
reviewed
Sep 30, 2022
- Update: direct_owned_parents methods: Temporarily commented out, pending OAK fixes. Currently doing this in batch using SPARQL for now. - Add: Param --onto-exclusions-path: Now we no longer consider exluded terms to be possible slurp candidates. - Bugfix: Labels: Now they are successfully being fetched using OAK. - Add: New columns to output Exclusions - Bugfix: Sometimes, when exclude_children was left empty in input config/%_exclusions.tsv, yielded empty generated exclusion tables. - Update: Updated exclusion tables for: DOID, OMIM. These had problematic source files with no values for exclude_children, and needed to be re-run after bugfix. Misc - Update: run.sh: Reverted back to what it was before, undoing deletion of --rf, which was done to address pip installs not being persistent within the ODK docker container between runs.
joeflack4
force-pushed
the
slurpdraft
branch
from
September 30, 2022 22:10
fd6f901
to
c27c449
Compare
joeflack4
reviewed
Sep 30, 2022
@matentzn This afternoon, did: (1) adding of genes to OMIM exclusions, re-ran exclusions pipeline and slurp, (2) re-ran slurp for all ontologies, following our addition/changes to columns. As you suggested, gonna merge this now. I imagine I'll be making continuous tweaks to the slurp pipeline very soon, but I'll make new (hopefully a lot smaller) PRs for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Related to