Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): fix map submission and editing ranked status #1063

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

petrecheli
Copy link
Contributor

@petrecheli petrecheli commented Oct 23, 2024

Closes #1051

Fix map submission and editing ranked status

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@petrecheli petrecheli changed the title fix(front): fix map submission and editing ranked way fix(front): fix map submission and editing ranked status Oct 23, 2024
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Angular forms are really gnarly, took me a moment to even remember how this stuff works, but I think you got it spot on.

@tsa96 tsa96 merged commit f4f998d into momentum-mod:main Oct 23, 2024
5 checks passed
@petrecheli
Copy link
Contributor Author

Thank you! It could be done in other ways, like using !item.type, but I think that would make the code less intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map submission ranked status is the wrong way around on display
2 participants