Generalized Map Versioning #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
refactor/map-versions
branch
3 times, most recently
from
1047a6f to
e88241a
Compare
apps/frontend/src/app/components/map-review/map-review-suggestions-form.component.ts
Outdated
Show resolved
Hide resolved
Panzerhandschuh
approved these changes
Sep 12, 2024
tsa96
force-pushed
the
refactor/map-versions
branch
from
e88241a to
150cb57
Compare
GordiNoki
requested changes
Sep 15, 2024
apps/frontend/src/app/pages/maps/map-info/map-info.component.html
Outdated
Show resolved
Hide resolved
apps/frontend/src/app/components/search/user-search.component.html
Outdated
Show resolved
Hide resolved
Nope not a problem for us, our HTTP downloader code just fetches a big ol' buffer and we can write it wherever. |
tsa96
force-pushed
the
refactor/map-versions
branch
from
150cb57 to
b98b263
Compare
tsa96
force-pushed
the
refactor/map-versions
branch
from
b98b263 to
9de9661
Compare
tsa96
force-pushed
the
refactor/map-versions
branch
from
9de9661 to
813ff53
Compare
GordiNoki
approved these changes
Sep 17, 2024
|
Not a big deal in this case but would prefer you let me merge my PRs @GordiNoki, at least when it's backend changes - when we have corresponding changes in red it's easiest if they all get in at once. If it's something you're waiting on feel free to badger me or nick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1006
Closes #857
Replaces the
MapSubmissionVersiontable withMapVersion. Map storage is now always using the zone system, even for approved maps. Previously, prior to approval maps, would be stored atsubmissions/<MapSubmissionVersion UUID ID>.bsp, then upon approval moved tomaps/<map name>.bsp. Now, all maps are just stored atmaps/<MapVersion UUID ID>.bsp. This makes frontend and game code quite a lot simpler.Whilst I haven't done admin map updating quite yet (#916), this change is essential to that system.
Also, since zones are now always stored on MapVersion, so always requires a join table to fetch, it's a lot easier to avoid fetching the zones JSON unnecessarily, plus I added Prisma's preview "omit" API which simplifies code even more. So #857 can be closed in the process.
Checks
nx run db:create-migrationand committed the migration if I've made DB schema changesfeat: Add foo,chore: Update bar, etc...fixuped into my original commits