Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fafmip access #286

Closed
wants to merge 11 commits into from
Closed

Fafmip access #286

wants to merge 11 commits into from

Conversation

russfiedler
Copy link
Collaborator

These commits address issues that arose when fixing the frazil computation for the ACCESS suite of models.

  1. Compute frazil formed using redistributed heat "temperature"
  2. Pass equivalent "redistributed potential temperature" to the coupler when conservative temperature is used as the prognostic temperature.
  3. The diagnostic temperature was being passed to the diagnostic package at time taup1 rather than time tau as verified by snapshots with contemp_equal_pottemp .eqv. .TRUE.

#280

#284

#285

@russfiedler
Copy link
Collaborator Author

@Fabiodias Could you describe the test runs you did with this commit so we can get it accepted?

@fabiobdias
Copy link

fabiobdias commented Jun 5, 2019

Hi @russfiedler,

I have performed the FAFMIP sanity test (using "do_fafmip_heat = true." but using "temp_correction_scale = 0.0") and can confirm that the variables "temp" and "redist_heat" are equal through the simulation (6-month long).

I also have performed a control run ("do_fafmip_heat = false.") and can confirm that the variable "temp" is equal in both control and sanity test experiments (when using "pottemp_equal_contemp = true"). (This is not the case for control x sanity test using "pottemp_equal_contemp = false", with small differences appearing after a few timesteps).

These two metrics were previously related with the fixes (1) and (2) Russ wrote in the first comment.

I also can certify that the fix (3) is working and the variables "pot_temp" and "temp" (conservative temperature) are equal for every time outputted. This wasn't the case for runs previous of this fix.

@russfiedler
Copy link
Collaborator Author

The recent fafmip_stress pull request #290 includes all the changes here. I'll close this request.

@russfiedler russfiedler deleted the fafmip_access branch September 11, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants