-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugs are fixed in 2 files: #249
base: master
Are you sure you want to change the base?
Conversation
xiaobin1124
commented
Sep 30, 2018
1, fms_io.F90, kind=8 allow very large file size definitions. 2, fixed bugs in fregrid.c for vector regriding functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I would change the declaration in fms_io.F90
to
integer(LONG_KIND) :: var_sz, size_in_file ! The size in bytes of each variable and of the variables already in a file.
for consistency (and portability).
Hi @xiaobin1124, sorry for the long delay in replying to this. We've started to discuss how to improve governance of the code and how to keep track of these contributions. The Since these look like important changes, I would encourage you to also send these patches to the GFDL repositories while we work to integrate the MOM5 and FMS repos. FMS: FRE-NCtools: Thanks very much for the contribution! |
@russfiedler Thanks for your suggestion, I just made the change and recommited. |
@marshallward Thanks for reminding me, I will check whether these patches are still needed in the FMS repo. |