Skip to content

Commit

Permalink
Merge pull request #30 from molssi-seamm/dev
Browse files Browse the repository at this point in the history
Added typing for fluorobenzene to OPLS-AA
  • Loading branch information
paulsaxe authored Sep 7, 2023
2 parents a374aaf + 1ecdb13 commit 4b5d5f4
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 0 deletions.
2 changes: 2 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
History
=======

2023.9.7 -- Added typing in OPLS_AA for fluorobenzene

2023.9.6 -- Fixed issue with PF6- geometry
* The Lennard-Jones repulsive term added to the F-P-F angle was too weak, allowing the
structure to get trapped in a symmetric state with ~40º angles.
Expand Down
18 changes: 18 additions & 0 deletions forcefield_step/data/oplsaa.frc
Original file line number Diff line number Diff line change
Expand Up @@ -9228,6 +9228,24 @@
"overrides": []
}
},
"opls_659": {
"2023.09.07": {
"smarts": [
"[c:1]F"
],
"description": "aromatic carbon in fluorobenzene",
"overrides": []
}
},
"opls_660": {
"2023.09.07": {
"smarts": [
"c[F:1]"
],
"description": "fluorine in fluorobenzene",
"overrides": []
}
},
"opls_712": {
"2023.01.29": {
"smarts": [
Expand Down
12 changes: 12 additions & 0 deletions tests/test_oplsaa_assignment.py
Original file line number Diff line number Diff line change
Expand Up @@ -2661,6 +2661,18 @@ def test_opls_585(oplsaa_assigner, configuration):
print(f"Incorrect typing. Should be:\n {correct}\nnot\n {result}")
raise AssertionError(f"\n result: {result}\ncorrect: {correct}")

def test_opls_659(oplsaa_assigner, configuration):
"""Test of atom-type assignment for
opls 659, aromatic carbon in fluorobenzene
opls 660, chlorine in fluorobenzene
"""
correct = ["opls_660", "opls_659"] + 5 * ["opls_90"] + 5 * ["opls_91"]
configuration.from_smiles("Fc1ccccc1")
result = oplsaa_assigner.assign(configuration)
if result != correct:
print(f"Incorrect typing. Should be:\n {correct}\nnot\n {result}")
raise AssertionError(f"\n result: {result}\ncorrect: {correct}")

def test_opls_712(oplsaa_assigner, configuration):
"""Test of atom-type assignment for propylene carbonate
opls 712, carbonyl oxygen
Expand Down

0 comments on commit 4b5d5f4

Please sign in to comment.