-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use actuator/metrics for data points #615
Conversation
Weird error while testing on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed. For now I'm not going to comment on the composition/options api. We will the refactor for that later. I do think we need tests and the typing should be fixed. Do you have the following plugins in your vsCode:
TypeScript Vue Plugin
and Vue Language Features (Volar)
? I think it's the latter. I get error like these:
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve but please check if you can add smoketest for the '/actuator' and '/metrics'
I expect you would like to copy the test for the UserController
Actuator metrics
Current
Previous
Other Actuator
This makes discussion easier as the links are available.
We can use de standard items and build custom
make custom rock items available by their API likerserve.processes.current
already thereActuator
Metrics
By names
fetch by name
Groups
disk.free