Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Istio mTLS injection to Hub #352

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

Add Istio mTLS injection to Hub #352

wants to merge 55 commits into from

Conversation

aaronreynoza
Copy link
Member

@aaronreynoza aaronreynoza commented Sep 12, 2024

Labels sidecar.istio.io/inject: "false" have been added to resources incompatible with the Istio Mesh.

stateful resources are incompatible so injection label has been enabled only for mojaloop/mcm namespaces.

@aaronreynoza aaronreynoza changed the title Cto 18 Add Istio mTLS injection to Hub Sep 13, 2024
@aaronreynoza aaronreynoza marked this pull request as ready for review September 13, 2024 06:21
Copy link
Collaborator

@dfry dfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -3,5 +3,14 @@ apiVersion: v1
kind: Namespace
metadata:
name: ${ns}
# tried to implement OR operator but couldn't find a syntax for it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aaronreynoza
❌ KhaledSaiidi
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants