Add support for schemas inside of type to work with JSON Schema Draft 3 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @noahrc, if you resolve the conflict I'll merge this. |
|
Hi @mohsen1, sorry for the slow response on this. I rebased this PR off of master and squashed all of my previous changes into one commit (minus the changes you asked me to remove). Let me know if it needs anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for open-sourcing the great library! This PR adds support for displaying schemas inside of types to work with the previous draft of JSON Schema.
Not sure if you want this module to support the older schema version, but it was important for a project I'm on and I'm hoping the goal of the viewer is to be flexible.