Fix compilation with avr-gcc 7x #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May help #15, though avr-gcc 5.2 may be too out of date to parse some of the library. |
jwakely
reviewed
May 7, 2024
jwakely
reviewed
May 7, 2024
|
I just wanted to bump this item. Thanks @adbancroft this does interest us. I'll try to scrape up just a bit of time to take it down the GCC5 road and see what's up. I intend to look at it. It's just that this project is hard for me to find time for. Cc: @salkinium |
_GLIBCXX_USE_MAKE_INTEGER_SEQ was being tested before it was set.
|
So sorry for the wait, I completely forgot about this. I'll merge this on the weekend if there are no reviews by then. |
As did I also forget. Sorry also. Thank you @salkinium and @adbancroft for reporting this and working it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-instate 1e245c1, which was removed as part of 4fd647b.
This provides support for avr-gcc 7.x: this is the gcc version that Arduino ships with, so it's a popular platform.