Fix parsing and ToString not using invariant culture

src/netcore/EigenCore/Core/Dense/MatrixDenseBase.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Linq;
 using System.Text;
 using System.Text.RegularExpressions;
@@ -203,7 +204,7 @@ public override string ToString()
                 {
                     for (int col = 0; col < Cols; col++)
                     {
-                        stringBuilder.AppendFormat("{0:G3} ", Get(row, col));
+                        stringBuilder.AppendFormat(CultureInfo.InvariantCulture, "{0:G3} ", Get(row, col));
                     }
                     stringBuilder.Append('\n');
                 }

src/netcore/EigenCore/Core/Dense/MatrixXD.cs

@@ -2,6 +2,7 @@
 using EigenCore.Core.Dense.LinearAlgebra;
 using EigenCore.Core.Shared;
 using EigenCore.Eigen;
+using System.Globalization;
 using System.Linq;
 
 namespace EigenCore.Core.Dense
@@ -628,7 +629,7 @@ public FullPivLUResult FullPivLU()
 
         }
 
-        public override MatrixXD Clone()
+        public override MatrixDenseBase<double> Clone()
         {
             return new MatrixXD(_values.ToArray(), Rows, Cols);
         }
@@ -685,7 +686,7 @@ public MatrixXD(MatrixXD matrixXD)
         }
 
         public MatrixXD(string valuesString)
-            : base(valuesString, (string value) => double.Parse(value))
+            : base(valuesString, (string value) => double.Parse(value, CultureInfo.InvariantCulture))
         {
 
         }

src/netcore/EigenCore/Core/Dense/VBufferDense.cs

@@ -6,6 +6,11 @@ public abstract class VBufferDense<T>
     {
         protected readonly T[] _values;
 
+        /// <summary>
+        /// Use only for reading raw data efficiently.
+        /// </summary>
+        public T[] Values => _values;
+
         public readonly int Length;
 
         public ReadOnlySpan<T> GetValues() => _values.AsSpan(0, Length);

src/netcore/EigenCore/Core/Dense/VectorDenseBase.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Linq;
 using System.Text;
 using System.Text.RegularExpressions;
@@ -80,7 +81,7 @@ public override string ToString()
                     return stringBuilder.ToString().Trim();
                 }
 
-                stringBuilder.AppendFormat("{0:G3} ", _values[i]);
+                stringBuilder.AppendFormat(CultureInfo.InvariantCulture, "{0:G3} ", _values[i]);
             }
 
             return stringBuilder.ToString().Trim();

src/netcore/EigenCore/Core/Dense/VectorXD.cs

@@ -1,6 +1,7 @@
 using EigenCore.Core.Shared;
 using EigenCore.Eigen;
 using System;
+using System.Globalization;
 using System.Linq;
 
 namespace EigenCore.Core.Dense
@@ -149,7 +150,7 @@ public override int GetHashCode()
         }
 
         public VectorXD(string valuesString)
-            : base(valuesString, (string value) => double.Parse(value))
+            : base(valuesString, (string value) => double.Parse(value, CultureInfo.InvariantCulture))
         {
         }
 

src/netcore/EigenCore/Core/Sparse/MatrixSparseBase.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.Linq;
 using System.Text;
 
@@ -143,7 +144,7 @@ public override string ToString()
                 {
                     for (int col = 0; col < Cols; col++)
                     {
-                        stringBuilder.AppendFormat("{0:G3} ", Get(row, col));
+                        stringBuilder.AppendFormat(CultureInfo.InvariantCulture, "{0:G3} ", Get(row, col));
                     }
                     stringBuilder.Append('\n');
                 }

src/netcore/EigenCore/Core/Sparse/VectorSparseBase.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Linq;
 using System.Text;
 
@@ -79,7 +80,7 @@ public override string ToString()
                     return stringBuilder.ToString().Trim();
                 }
 
-                stringBuilder.AppendFormat("{0:G3} ", Get(i));
+                stringBuilder.AppendFormat(CultureInfo.InvariantCulture, "{0:G3} ", Get(i));
             }
 
             return stringBuilder.ToString().Trim();

src/netcore/EigenCore/EigenCore.csproj

@@ -1,11 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
+    <TargetFramework>netcoreapp2.1</TargetFramework>
     <Product />
     <Company />
     <Authors>modios</Authors>
-    <Version>1.0.0-alpha</Version>
+    <Version>1.0.2-alpha</Version>
     <Description>.Net wrapper for the Eigen C++ library</Description>
     <Copyright>modios</Copyright>
     <RepositoryUrl>https://github.com/modios/EigenCore</RepositoryUrl>