Merge pull request #2420 from modernweb-dev/dependabot/npm_and_yarn/e…

…sbuild-0.19.2 chore(deps): bump esbuild from 0.17.19 to 0.19.2
modernweb-dev · Nov 1, 2023 · bd7db2c · bd7db2c
2 parents c30b5dd + 7631d5e
commit bd7db2c
Show file tree

Hide file tree

Showing 8 changed files with 3,630 additions and 5,986 deletions.
diff --git a/.changeset/hungry-candles-carry.md b/.changeset/hungry-candles-carry.md
@@ -0,0 +1,9 @@
+---
+'@web/dev-server-esbuild': major
+---
+
+Update ESBuild to latest version.
+
+ESBuild has changed how TypeScript decorators are enabled in preparation for JavaScript decorators to land in browsers. ESBuild now requires the `experimentalDecorators` key to be set to `true` in the `tsconfig.json` for TypeScript decorators to be enabled.
+
+If you are having issues with decorators after updating to this version, try setting the `experimentalDecorators` key in your `tsconfig.json`.
diff --git a/.changeset/slimy-starfishes-prove.md b/.changeset/slimy-starfishes-prove.md
@@ -0,0 +1,5 @@
+---
+'rollup-plugin-workbox': minor
+---
+
+Update ESBuild to latest version
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dev-server-esbuild/package.json b/packages/dev-server-esbuild/package.json
@@ -52,8 +52,8 @@
   ],
   "dependencies": {
     "@mdn/browser-compat-data": "^4.0.0",
+    "esbuild": "^0.19.5",
     "@web/dev-server-core": "^0.6.2",
-    "esbuild": "^0.16 || ^0.17",
     "parse5": "^6.0.1",
     "ua-parser-js": "^1.0.33"
   },

diff --git a/packages/dev-server-esbuild/test/fixture/tsconfig-with-experimental-decorators.json b/packages/dev-server-esbuild/test/fixture/tsconfig-with-experimental-decorators.json
@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "experimentalDecorators": true
+  }
+}
diff --git a/packages/dev-server-esbuild/test/ts.test.ts b/packages/dev-server-esbuild/test/ts.test.ts
@@ -71,7 +71,10 @@ class Bar {
             }
           },
         },
-        esbuildPlugin({ ts: true }),
+        esbuildPlugin({
+          ts: true,
+          tsconfig: path.join(__dirname, 'fixture', 'tsconfig-with-experimental-decorators.json'),
+        }),
       ],
     });
 
@@ -84,7 +87,7 @@ class Bar {
         'application/javascript; charset=utf-8',
       );
       expectIncludes(text, '__decorate');
-      expectIncludes(text, 'this.x = "y";');
+      expectIncludes(text, '__publicField(this, "x", "y");');
       expectIncludes(
         text,
         `__decorateClass([

diff --git a/packages/rollup-plugin-workbox/package.json b/packages/rollup-plugin-workbox/package.json
@@ -32,7 +32,7 @@
     "workbox"
   ],
   "dependencies": {
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.19.5",
     "pretty-bytes": "^5.5.0",
     "workbox-build": "^7.0.0"
   },

diff --git a/packages/storybook-builder/package.json b/packages/storybook-builder/package.json
@@ -59,7 +59,7 @@
     "@web/rollup-plugin-html": "^2.0.0",
     "browser-assert": "^1.2.1",
     "es-module-lexer": "^1.2.1",
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.19.5",
     "express": "^4.18.2",
     "fs-extra": "^11.1.1",
     "glob-promise": "^6.0.3",