Merge pull request #2648 from koddsson/set-fetchpriority-for-polyfill…

…s-to-high Set fetchPriority of polyfills to high
modernweb-dev · Feb 22, 2024 · a0f330f · a0f330f
2 parents b8d60e1 + 8b5a833
commit a0f330f
Show file tree

Hide file tree

Showing 37 changed files with 47 additions and 1 deletion.
diff --git a/.changeset/pretty-days-raise.md b/.changeset/pretty-days-raise.md
@@ -0,0 +1,5 @@
+---
+'@web/polyfills-loader': minor
+---
+
+Set fetchPriority of polyfill scripts to `high`
diff --git a/packages/polyfills-loader/src/createPolyfillsLoader.ts b/packages/polyfills-loader/src/createPolyfillsLoader.ts
@@ -21,6 +21,7 @@ const loadScriptFunction = `
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);
@@ -221,6 +222,7 @@ export async function createPolyfillsLoader(
 
       if (${coreJs.test}) {
         var s = document.createElement('script');
+        s.fetchPriority = 'high';
         function onLoaded() {
           document.head.removeChild(s);
           polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/absolute-file-path.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/absolute-file-path.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/custom-polyfills-dir.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/custom-polyfills-dir.js
@@ -3,6 +3,7 @@
     function loadScript(src, type, attributes) {
       return new Promise(function (resolve) {
         var script = document.createElement('script');
+        script.fetchPriority = 'high';
         function onLoaded() {
           if (script.parentElement) {
             script.parentElement.removeChild(script);
@@ -45,6 +46,7 @@
   }
   if (!('noModule' in HTMLScriptElement.prototype)) {
     var s = document.createElement('script');
+    s.fetchPriority = 'high';
     function onLoaded() {
       document.head.removeChild(s);
       polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/minified.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/minified.js
diff --git a/...es/polyfills-loader/test/snapshots/createPolyfillsLoader/module-legacy-system-multiple.js b/...es/polyfills-loader/test/snapshots/createPolyfillsLoader/module-legacy-system-multiple.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-legacy-system.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-legacy-system.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-resource.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-resource.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-resources.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-resources.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-shim-resource.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/module-shim-resource.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/multiple-legacy.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/multiple-legacy.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/no-polyfills-no-legacy.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/no-polyfills-no-legacy.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills-initializer.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills-initializer.js
@@ -3,6 +3,7 @@
     function loadScript(src, type, attributes) {
       return new Promise(function (resolve) {
         var script = document.createElement('script');
+        script.fetchPriority = 'high';
         function onLoaded() {
           if (script.parentElement) {
             script.parentElement.removeChild(script);
@@ -50,6 +51,7 @@
   }
   if (!('noModule' in HTMLScriptElement.prototype)) {
     var s = document.createElement('script');
+    s.fetchPriority = 'high';
     function onLoaded() {
       document.head.removeChild(s);
       polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills-module.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills-module.js
@@ -3,6 +3,7 @@
     function loadScript(src, type, attributes) {
       return new Promise(function (resolve) {
         var script = document.createElement('script');
+        script.fetchPriority = 'high';
         function onLoaded() {
           if (script.parentElement) {
             script.parentElement.removeChild(script);
@@ -28,6 +29,7 @@
   }
   if (!('noModule' in HTMLScriptElement.prototype)) {
     var s = document.createElement('script');
+    s.fetchPriority = 'high';
     function onLoaded() {
       document.head.removeChild(s);
       polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/polyfills.js
@@ -3,6 +3,7 @@
     function loadScript(src, type, attributes) {
       return new Promise(function (resolve) {
         var script = document.createElement('script');
+        script.fetchPriority = 'high';
         function onLoaded() {
           if (script.parentElement) {
             script.parentElement.removeChild(script);
@@ -45,6 +46,7 @@
   }
   if (!('noModule' in HTMLScriptElement.prototype)) {
     var s = document.createElement('script');
+    s.fetchPriority = 'high';
     function onLoaded() {
       document.head.removeChild(s);
       polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/relative-polyfills-dir.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/relative-polyfills-dir.js
@@ -3,6 +3,7 @@
     function loadScript(src, type, attributes) {
       return new Promise(function (resolve) {
         var script = document.createElement('script');
+        script.fetchPriority = 'high';
         function onLoaded() {
           if (script.parentElement) {
             script.parentElement.removeChild(script);
@@ -45,6 +46,7 @@
   }
   if (!('noModule' in HTMLScriptElement.prototype)) {
     var s = document.createElement('script');
+    s.fetchPriority = 'high';
     function onLoaded() {
       document.head.removeChild(s);
       polyfillsLoader();

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/script-resource.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/script-resource.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/system-resource.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/system-resource.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/upwards-file-path.js b/packages/polyfills-loader/test/snapshots/createPolyfillsLoader/upwards-file-path.js
@@ -2,6 +2,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-and-legacy.html b/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-and-legacy.html
@@ -5,6 +5,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-and-polyfills.html b/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-and-polyfills.html
@@ -5,6 +5,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/...es/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-polyfills-and-legacy.html b/...es/polyfills-loader/test/snapshots/injectPolyfillsLoader/module-polyfills-and-legacy.html
@@ -5,6 +5,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/multiple-legacy.html b/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/multiple-legacy.html
@@ -5,6 +5,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/no-importmap-polyfill.html b/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/no-importmap-polyfill.html
@@ -8,6 +8,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/no-polyfills-no-legacy.html b/packages/polyfills-loader/test/snapshots/injectPolyfillsLoader/no-polyfills-no-legacy.html
@@ -8,6 +8,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/...fills-loader/test/snapshots/injectPolyfillsLoader/systemjs-polyfill-importmap-legacy.html b/...fills-loader/test/snapshots/injectPolyfillsLoader/systemjs-polyfill-importmap-legacy.html
@@ -8,6 +8,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/...fills-loader/test/snapshots/injectPolyfillsLoader/systemjs-polyfill-importmap-modern.html b/...fills-loader/test/snapshots/injectPolyfillsLoader/systemjs-polyfill-importmap-modern.html
@@ -8,6 +8,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/customize-filetype-multi-output.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/customize-filetype-multi-output.html
@@ -4,6 +4,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/customize-filetype.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/customize-filetype.html
@@ -4,6 +4,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/flattened.html
@@ -6,6 +6,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/...rollup-plugin-polyfills-loader/test/snapshots/multiple-entrypoints-retain-attributes.html b/...rollup-plugin-polyfills-loader/test/snapshots/multiple-entrypoints-retain-attributes.html
@@ -6,6 +6,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/multiple-entrypoints.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/multiple-entrypoints.html
@@ -6,6 +6,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/multiple-outputs.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/multiple-outputs.html
@@ -4,6 +4,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/non-flattened.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/non-flattened.html
@@ -6,6 +6,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/polyfills.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/polyfills.html
@@ -4,6 +4,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/single-output.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/single-output.html
@@ -4,6 +4,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);

diff --git a/packages/rollup-plugin-polyfills-loader/test/snapshots/systemjs.html b/packages/rollup-plugin-polyfills-loader/test/snapshots/systemjs.html
@@ -6,6 +6,7 @@
   function loadScript(src, type, attributes) {
     return new Promise(function (resolve) {
       var script = document.createElement('script');
+      script.fetchPriority = 'high';
       function onLoaded() {
         if (script.parentElement) {
           script.parentElement.removeChild(script);