Merge pull request #2549 from koddsson/remove-code-for-old-node-versions

Remove old node runtime specific code
modernweb-dev · Nov 11, 2023 · 6eceb7e · 6eceb7e
2 parents f559302 + 5b6e1bc
commit 6eceb7e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 50 deletions.
diff --git a/.changeset/empty-ads-agree.md b/.changeset/empty-ads-agree.md
@@ -0,0 +1,5 @@
+---
+'@web/config-loader': patch
+---
+
+Drop support for older node runtimes (12 and earlier)
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/config-loader/package.json b/packages/config-loader/package.json
@@ -39,7 +39,6 @@
     "es module"
   ],
   "dependencies": {
-    "semver": "^7.3.4"
   },
   "types": "dist/index.d.ts",
   "exports": {

diff --git a/packages/config-loader/src/importConfig.js b/packages/config-loader/src/importConfig.js
@@ -1,9 +1,6 @@
-const semver = require('semver');
 const { pathToFileURL } = require('url');
 const ConfigLoaderError = require('./ConfigLoaderError');
 
-const supportsEsm = semver.satisfies(process.version, '>=12.17.0');
-
 // These strings may be node-version dependent and need updating over time
 // They're just to display a helpful error message
 const CJS_ERRORS = [
@@ -16,14 +13,6 @@ const CJS_ERRORS = [
  * @param {string} path
  */
 async function importConfig(path) {
-  if (!supportsEsm) {
-    throw new ConfigLoaderError(
-      'You are trying to load a config as es module but your version of node does not support it. ' +
-        'Update to node v12.17.0 or higher, or load the config as commonjs by using the .cjs extension ' +
-        'or .js without type="module" set in your package.json',
-    );
-  }
-
   try {
     const config = await import(pathToFileURL(path).href);
 

diff --git a/packages/config-loader/test/index.test.js b/packages/config-loader/test/index.test.js
@@ -1,10 +1,7 @@
 const path = require('path');
 const { expect } = require('chai');
-const semver = require('semver');
 const { readConfig } = require('../src/index');
 
-// some tests are specific for node < v12.17.0
-const supportsEsm = semver.satisfies(process.version, '>=12.17.0');
 const configName = 'my-project.config';
 const packageCjsPath = path.resolve(__dirname, 'fixtures', 'package-cjs');
 const packageMjsPath = path.resolve(__dirname, 'fixtures', 'package-mjs');
@@ -41,7 +38,6 @@ describe('cjs package', () => {
     expect(result).to.eql({ foo: 'bar' });
   });
 
-  if (supportsEsm) {
     it('can load module-in-.mjs', async () => {
       const result = await readConfig(
         configName,
@@ -50,11 +46,6 @@ describe('cjs package', () => {
       );
       expect(result).to.eql({ foo: 'bar' });
     });
-  } else {
-    it('throws an error when trying to load a mjs file', async () => {
-      await expectThrowsOldNodeError(path.resolve(packageCjsPath, 'module-in-.mjs'));
-    });
-  }
 
   it('throws when loading module-in-.cjs', async () => {
     let thrown = false;
@@ -82,7 +73,6 @@ describe('cjs package', () => {
     expect(thrown).to.equal(true);
   });
 
-  if (supportsEsm) {
     it('throws when loading commonjs-in-.mjs', async () => {
       let thrown = false;
       try {
@@ -95,7 +85,6 @@ describe('cjs package', () => {
       }
       expect(thrown).to.equal(true);
     });
-  }
 });
 
 describe('mjs package', () => {
@@ -108,7 +97,6 @@ describe('mjs package', () => {
     expect(result).to.eql({ foo: 'bar' });
   });
 
-  if (supportsEsm) {
     it('throws when loading commonjs-in-.js', async () => {
       let thrown = false;
       try {
@@ -121,13 +109,7 @@ describe('mjs package', () => {
       }
       expect(thrown).to.equal(true);
     });
-  } else {
-    it('throws an error when trying to load commonjs-in-.js', async () => {
-      await expectThrowsOldNodeError(path.resolve(packageMjsPath, 'commonjs-in-.js'));
-    });
-  }
 
-  if (supportsEsm) {
     it('throws when loading commonjs-in-.mjs', async () => {
       let thrown = false;
       try {
@@ -140,11 +122,6 @@ describe('mjs package', () => {
       }
       expect(thrown).to.equal(true);
     });
-  } else {
-    it('throws an error when trying to load commonjs-in-.mjs', async () => {
-      await expectThrowsOldNodeError(path.resolve(packageMjsPath, 'commonjs-in-.mjs'));
-    });
-  }
 
   it('throws when loading module-in-.cjs', async () => {
     let thrown = false;
@@ -159,7 +136,6 @@ describe('mjs package', () => {
     expect(thrown).to.equal(true);
   });
 
-  if (supportsEsm) {
     it('can load module-in-.js', async () => {
       const result = await readConfig(
         configName,
@@ -168,13 +144,7 @@ describe('mjs package', () => {
       );
       expect(result).to.eql({ foo: 'bar' });
     });
-  } else {
-    it('throws an error when trying to load module-in-.js', async () => {
-      await expectThrowsOldNodeError(path.resolve(packageMjsPath, 'module-in-.js'));
-    });
-  }
 
-  if (supportsEsm) {
     it('can load module-in-.mjs', async () => {
       const result = await readConfig(
         configName,
@@ -183,9 +153,4 @@ describe('mjs package', () => {
       );
       expect(result).to.eql({ foo: 'bar' });
     });
-  } else {
-    it('throws an error when trying to load a mjs file', async () => {
-      await expectThrowsOldNodeError(path.resolve(packageMjsPath, 'module-in-.mjs'));
-    });
-  }
 });