Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Classification support #19

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

peter-lobner
Copy link
Contributor

Adds support fro srmd classifications via an GElementCommont group that wraps annotations and classifications.
Therefore srmd classifications can be used with all entities that are annotatable.

@peter-lobner peter-lobner marked this pull request as draft November 2, 2023 14:05
@peter-lobner
Copy link
Contributor Author

Documentation is currently missing

@pmai
Copy link
Collaborator

pmai commented Nov 3, 2023

Can this (and the other PR) be redone so that there are actual clean diffs (i.e. no changes in whitespace and other formatting that makes the changes very hard to review and also impossible to merge as is)? It also seems to me, but again hard to check with all the superfluous changes, that this touches more places than it technically needs to.

Other than that this PR is misnamed: It does not add SRMD support at all, it adds classifications. SRMD is a stand-alone file format, not the SSP Traceability classifications.

I think that SSP should first add support for specifying per-element (and other entities, like parameter sets, ...) generic meta-data support, which could then be used to point to / embed SRMD files and other format meta-data.

That SSP might also want to add classifications for all modeling elements is I think another issue.

@peter-lobner peter-lobner changed the title Add SRMD support Add Classification support Nov 3, 2023
@peter-lobner
Copy link
Contributor Author

Any ideas what formatting settings to use? I use XML Spy.

@pmai
Copy link
Collaborator

pmai commented Nov 3, 2023

Any ideas what formatting settings to use? I use XML Spy.

Ideally tell XML Spy to not touch anything that you are not changing, and to use 4 spaces no tabs indentation. Not sure how to tell XML Spy this, I tend never to use it.

It is usually easier to work with editors in textual mode, as for any other language, as this allows clearer control of the stuff changed...

@peter-lobner
Copy link
Contributor Author

peter-lobner commented Nov 3, 2023

I think that SSP should first add support for specifying per-element (and other entities, like parameter sets, ...) generic meta-data support, which could then be used to point to / embed SRMD files and other format meta-data.

That SSP might also want to add classifications for all modeling elements is I think another issue.

I think that can easily be incorporated in the current proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants