-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use annotations to mark configuration variables #69
Conversation
I think if we are going to refactor the LS-XCP, due to also the missing ability to support more than one A2L file/XCP slave, then I think the better alternative would be to just name the variables in the manifest file of the ls-xcp, which, if we go down the route of not having fixed names, seems preferable, as it is more self-contained. It would also allow for grouping, so that we can have a wrapper element, which makes support for multiple A2L files and multiple XCP slaves simpler: e.g.: <?xml version="1.0" encoding="UTF-8"?>
<fmiLayeredStandardManifest
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../schema/fmi3LayeredStandardXcpManifest.xsd"
xmlns:fmi-ls="http://fmi-standard.org/fmi-ls-manifest"
fmi-ls:fmi-ls-name="org.fmi-standard.fmi-ls-xcp"
fmi-ls:fmi-ls-version="1.0.0-rc.4"
fmi-ls:fmi-ls-description="Layered standard based on FMI 2.0 and FMI 3.0 for describing and implementing XCP support for FMUs, which can either provide an XCP service or allow direct memory access via A2L files.">
<access identifier="foo"
containsXcpService="true"
supportsDirectMemoryAccessViaA2L="true"
EnableXcpOnTcpIpVariable="top.EnableXcpOnTcpIp"
EnableXcpOnUdpIpVariable="top.EnableXcpOnUdpIp"
TcpListenIpAddressVariable="top.TcpListenIpAddress"
TcpListenPortNumberVariable="top.TcpListenPortNumber"
UdpListenIpAddressVariable="top.UdpListenIpAddress"
UdpListenPortNumberVariable="top.UdpListenPortNumber"/>
<access identifier="bar"
containsXcpService="true"
supportsDirectMemoryAccessViaA2L="false"
EnableXcpOnTcpIpVariable="org.fmi_standard.fmi_ls_xcp.EnableXcpOnTcpIp"
TcpListenPortNumberVariable="org.fmi_standard.fmi_ls_xcp.TcpListenPortNumber"/>
</fmiLayeredStandardManifest> I've prepared a PR which sketches this approach out. |
Pierre will close this in favour of #76 |
* Initial sketch of manifest-based naming and multi A2L (fixes #63). * Add documentation for manifest-based variable naming * Regularize naming of attributes (fixes #68, #78, #79). * Incorporate formatting changes from #69 by @t-sommer. * Broader refactoring of manifest mechanism and naming (fixes #80). * Add ability to restrict Interface to certain CS/ME/SE (fixes #83). * Validate examples in CI * Use curly braces for protocol alternatives * Extend description of "types" attribute * Fix role attribute for XCP.vECU1.UDP.* variables * Fix list * Some small formal changes * Adjust wording and add IPv6 addresses Signed-off-by: Pierre R. Mai <[email protected]> Co-authored-by: Torsten Sommer <[email protected]> Co-authored-by: Patrick Taeuber <[email protected]>
fixes #64