Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getPort function for tomcat-8.5 #734

Closed
wants to merge 1 commit into from
Closed

Fix getPort function for tomcat-8.5 #734

wants to merge 1 commit into from

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Sep 22, 2023

@jajik jajik requested a review from rhusar as a code owner September 22, 2023 08:30
@jajik
Copy link
Collaborator Author

jajik commented Sep 22, 2023

It's possible that the fix is not correct, because other tomcats work fine and their getPort functions don't use getPortWithOffset. I'll look into it more if I have some time.

@jajik jajik added the bug label Sep 22, 2023
@jajik
Copy link
Collaborator Author

jajik commented Sep 25, 2023

Ok, I was too fast again, this won't solve the issue. I will close this PR (I can't see the convert to draft option) and open another one once I solve it properly.

@jajik jajik closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar Awaiting requested review from rhusar rhusar is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jajik