Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception. #717

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Prevent exception. #717

merged 1 commit into from
Aug 2, 2023

Conversation

jfclere
Copy link
Member

@jfclere jfclere commented Jul 28, 2023

While doing test deploying and undeploying webapps by adding and removing war files I noted the exception, so here is the PR. Same occurs on 1.4.x

@jfclere jfclere requested a review from rhusar as a code owner July 28, 2023 14:27
@jfclere jfclere changed the title Prevent expection. Prevent exception. Jul 28, 2023
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a JIRA for this + linked from commit. But mainly, this sounds like a bug in how we handle the lifecycle.

@rhusar
Copy link
Member

rhusar commented Jul 28, 2023

@rhusar rhusar added the hold label Jul 28, 2023
@rhusar
Copy link
Member

rhusar commented Jul 28, 2023

Let me put a hold on this for now until I open a proper fix for MODCLUSTER-790 but in the meantime, can you described the reproducer (perhaps in the Jira)?

n.b. this would be Tomcat-only bug - not WildFly one.

@rhusar
Copy link
Member

rhusar commented Aug 2, 2023

I ll just link this to MODCLUSTER-790.

@rhusar rhusar merged commit 24894ae into modcluster:main Aug 2, 2023
12 checks passed
@rhusar
Copy link
Member

rhusar commented Aug 2, 2023

Merged, thanks @jfclere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants