Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch VolumeFsVersion enum fields to proper standard #2432

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Oct 31, 2024

Will delete the old fields in a separate PR later today.

@erikbern erikbern requested a review from mwaskom October 31, 2024 14:48
@@ -235,9 +235,13 @@ enum TaskState {
}

enum VolumeFsVersion {
option allow_alias = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, TIL

@erikbern erikbern merged commit 754fa03 into main Oct 31, 2024
23 checks passed
@erikbern erikbern deleted the erikbern/volume-fs-version branch October 31, 2024 15:06
@danielnorberg
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants