-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align sandbox exec arguments with subprocess #2419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments and major realizations :D
bca1027
to
0c38119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! didn't look to closely at the internals, but the public API makes sense to me! wdyt @mwaskom ?
This commit adds new sandbox exec arguments, allowing the user to speicfy if they want to consume a stream directly, ignore the result, or consume it via a pipe.
0c38119
to
55aae42
Compare
@prbot automerge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some required workflows are pending. Will automerge once they complete successfully. Please bear with us in this difficult time.
Describe your changes
This commit adds new sandbox exec arguments, allowing the user to specify if they want to consume a stream directly, ignore the result, or consume it via a pipe.
Resolves WRK-422
Resolves WRK-413
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
I've tested this behavior out locally:
Changelog
Output from
Sandbox.exec
can now be directed to/dev/null
,stdout
, or stored for consumption. This behavior can be controlled via the newStreamType
arguments.