MOD-2454: add async_chain #2418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom/mod-2454-remove-aiostream-dependency-async-concat
kramstrom
changed the title
kramstrom
changed the title
…cy-cancellation-handling
3 tasks
freider
reviewed
Oct 30, 2024
modal/_utils/async_utils.py
Outdated
|
|
||
|
|
||
| async def async_concat(*iterables): | ||
| for it in iterables: |
There was a problem hiding this comment.
nit: In some of our other generators we "take ownership" of the input iterables and make sure to cancel/close them if the generator itself is cancelled/closed. Might want to be consistent in how we do this across all of these utils
…rom/mod-2454-remove-aiostream-dependency-cancellation-handling
…tion-handling' of github.com:modal-labs/modal-client into kramstrom/mod-2454-remove-aiostream-dependency-async-concat
…tion-handling' of github.com:modal-labs/modal-client into kramstrom/mod-2454-remove-aiostream-dependency-async-concat
…tion-handling' of github.com:modal-labs/modal-client into kramstrom/mod-2454-remove-aiostream-dependency-async-concat
…rom/mod-2454-remove-aiostream-dependency-async-concat
…rom/mod-2454-remove-aiostream-dependency-async-concat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
async_chainwhich allows you to concat different async generators and iterate through them sequentiallyDepends on #2421 for some general fixes for
async_utilsmethods