-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send terminated output when canceling a concurrent input. #2382
Send terminated output when canceling a concurrent input. #2382
Conversation
|
We might also want to add some assertions in relevant container_tests (there are plenty for various different cancellation conditions) that |
42fa468
to
6e00066
Compare
e382543
to
eb5d6cb
Compare
8fab2e4
to
b41b8d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
846f669
to
c2e1f07
Compare
The worker will ignore the terminated outputs for now. We should wait until at least Thursday 4pm ET before releasing this to ensure all workers have rolled out with the ignoring logic.
Context in WRK-11.