Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to stop apps programmatically #2352

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Oct 18, 2024

Really just moving some code from the cli package into the main code.

However I realized it's a bit janky because ideally you'd want this to be an instance method, and not a class method. But that would require better ways to construct an App object directly. Which we don't. We should address this though!

Also cleaned up some synchronicity stuff.

@mwaskom
Copy link
Contributor

mwaskom commented Oct 18, 2024

But that would require better ways to construct an App object directly.

we have App.lookup now; do you mean something other than that?

@erikbern
Copy link
Contributor Author

we have App.lookup now; do you mean something other than that?

Yeah the CLI lets you pass either an app name or an id – so we would need something to construct an app from an id.

Maybe I should just add that. It would be pretty similar to how lookup works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants