A few opportunistic improvements to type annotations #1814
Conversation
| @@ -27,7 +28,7 @@ def _get_environment_name(environment_name: Optional[str], resolver: Optional[Re | |||
| return config.get("environment") | |||
|
|
|||
|
|
|||
| class _Object: | |||
| class _Object(Generic[O]): | |||
There was a problem hiding this comment.
I am not totally sure that inheriting from Generic here makes sense, although it did silence the typing error we were otherwise getting here. I say that because the O TypeVar is used to represent specific subclasses, rather than a different type of object that this class can act on. What do you think @freider?
There was a problem hiding this comment.
Yeah it's a bit ugly, but I guess we need it if we want the class level annotations for _load and _preload to use the specific subclass :( Not sure if it's worth the extra typing complexity w/ Generic since _load and _preload are quite internal and we could add explicit typing in other places to make the code safe when using them, but I don't have a super strong feeling about it
mwaskom
force-pushed
the
michael/small-type-fixes
branch
from
e4c3e11
to
5c087ba
Compare
inv type-stubstask to remove all existing.pyifiles before running