Lexically split entrypoint command for modal shell #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something like this didn't previously work:
$ modal shell --cmd 'bash -c bash'
Failed to run command: No such file or directory
Because we were translating it to `CMD ["bash -c bash"]` underneath,
which tries to execute a binary literally named "bash -c bash". The
right thing to do is to translate it to `CMD ["bash", "-c", "bash"]`,
which we now do.
Basically now you can pass in arbitrarily sophisticated
commands through --cmd, like:
$ modal shell ollama-modal.py \
--cmd 'bash -c "systemctl start ollama; sleep 1; ollama run llama3:instruct"'
(Maybe there's appetite for everything being passed through 'bash -c' by
default?)
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
@prbot automerge |
irfansharif
added a commit
to irfansharif/ollama-modal
that referenced
this pull request
May 9, 2024
Improved after: - modal-labs/modal-client#1806 - modal-labs/modal-client#1807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this didn't previously work:
Because we were translating it to
CMD ["bash -c bash"]underneath, which tries to execute a binary literally named "bash -c bash". The right thing to do is to translate it toCMD ["bash", "-c", "bash"], which we now do.Basically now you can pass in arbitrarily sophisticated commands through --cmd, like:
(Maybe there's appetite for everything being passed through 'bash -c' by default?)