Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more context for generic remote deserialization errors #1783

Merged
merged 1 commit into from
May 1, 2024
Merged

Add more context for generic remote deserialization errors #1783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modal/_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,15 @@ def deserialize(s: bytes, client) -> Any:
f"Deserialization failed because the '{exc.name}' module is not available in the {env} environment."
) from exc
except Exception as exc:
if env == "remote":
# We currently don't always package the full traceback from errors in the remote entrypoint logic.
# So try to include as much information as we can in the main error message.
more = f": {type(exc)}({str(exc)})"
else:
# When running locally, we can just rely on standard exception chaining.
more = " (see above for details)"
raise DeserializationError(
f"Encountered an error when deserializing an object in the {env} environment (see above for details)."
f"Encountered an error when deserializing an object in the {env} environment{more}."
) from exc


Expand Down
Loading