Improve the error message for unhydrated objects #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
def seems like an upgrade so 👍 i think we could probably infer from the environment what's going on even more dynamically. e.g. if it's a function on a non-running app, we could say that. |
erikbern
approved these changes
Apr 30, 2024
|
OK, a little sketchy, but I added some logic to try and get the function name and whether the app is running in some places. Not totally obvious how to do that so could maybe be improved further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a persistent source of confusion. I am pretty sure that the main cause of this error (these days at least) is when users try to do
func.remote()or similar in a "bare" Python script, or when they have multiple apps and are running a different one. I am fairly certain that we now catch "not in global scope" at function wrapping time, and storage objects can now be lazily hydrated.I also don't think that mentioning "lazily hydrated" is helpful since that's an implementation detail and not something a user can understand or act on.
It might be helpful to add some Function-specific logic to include the function name in the error message, but I wasn't sure what the best way to approach that was, so I went for a smaller improvement.