Remove on_shutdown/set_pre_stop #1523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes occational exit spam, especially in tests, when an error occurs in the exit handler due to not being able to connect etc. I *think* we don't need it anymore since `_run_stub`'s finally-block appears to trigger disconnect on KeyboardInterrupt. I haven't been able to repro the old race
|
Ah I think I had tried this and ran into the same issue — so lovely to be able to scroll right to the test results though!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes occational exit spam, especially in tests, when an error occurs in the exit handler due to not being able to connect etc.
I think we don't need it anymore since
_run_stub's finally-block appears to trigger disconnect properly on KeyboardInterrupt now. I haven't been able to repro the old race (CC @thundergolfer who fought with this bug back in the day)