Skip to content

Commit

Permalink
Push it off to May 1
Browse files Browse the repository at this point in the history
  • Loading branch information
erikbern committed May 1, 2024
1 parent 4fb8c36 commit ed00530
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion modal/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ def function(

if interactive:
deprecation_error(
(2024, 2, 29), "interactive=True has been deprecated. Set MODAL_INTERACTIVE_FUNCTIONS=1 instead."
(2024, 5, 1), "interactive=True has been deprecated. Set MODAL_INTERACTIVE_FUNCTIONS=1 instead."
)

if image is None:
Expand Down
2 changes: 1 addition & 1 deletion modal/cli/import_refs.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def get_by_object_path_try_possible_app_names(obj: Any, obj_path: Optional[str])
return stub
elif isinstance(stub, App):
deprecation_warning(
(2024, 4, 29),
(2024, 5, 1),
"The symbol `app` is not present but `stub` is. This will not work in future"
" Modal versions. Suggestion: change the name of `stub` to `app`.",
pending=True
Expand Down
4 changes: 2 additions & 2 deletions modal/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -516,12 +516,12 @@ async def _interactive_shell(_app: _App, cmd: List[str], environment_name: str =


def _run_stub(*args, **kwargs):
deprecation_warning((2024, 4, 29), "`run_stub` is deprecated. Please use `run_app` instead.", pending=True)
deprecation_warning((2024, 5, 1), "`run_stub` is deprecated. Please use `run_app` instead.", pending=True)
return _run_app(*args, **kwargs)


def _deploy_stub(*args, **kwargs):
deprecation_warning((2024, 4, 29), "`deploy_stub` is deprecated. Please use `deploy_app` instead.", pending=True)
deprecation_warning((2024, 5, 1), "`deploy_stub` is deprecated. Please use `deploy_app` instead.", pending=True)
return _deploy_app(*args, **kwargs)


Expand Down
2 changes: 1 addition & 1 deletion modal/serving.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async def _serve_app(


def _serve_stub(*args, **kwargs):
deprecation_warning((2024, 4, 29), "`serve_stub` is deprecated. Please use `serve_app` instead.", pending=True)
deprecation_warning((2024, 5, 1), "`serve_stub` is deprecated. Please use `serve_app` instead.", pending=True)
return _run_app(*args, **kwargs)


Expand Down

0 comments on commit ed00530

Please sign in to comment.