Incorporate feedback

modal-labs · May 8, 2024 · da7aaf5 · da7aaf5
1 parent 328fdcd
commit da7aaf5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/modal/app.py b/modal/app.py
@@ -551,7 +551,7 @@ def wrapped(
 
             # Check if the decorated object is a class
             if inspect.isclass(f):
-                raise TypeError("The @app.function decorator cannot be used on a class.")
+                raise TypeError("The @app.function decorator cannot be used on a class. Please use @app.cls instead.")
 
             if isinstance(f, _PartialFunction):
                 f.wrapped = True

diff --git a/test/app_test.py b/test/app_test.py
@@ -277,14 +277,12 @@ def f():
 
 def test_function_decorator_on_class():
     app = App()
-    with pytest.raises(TypeError) as excinfo:
+    with pytest.raises(TypeError, match="cannot be used on a class"):
 
         @app.function()
         class Foo:
             pass
 
-    assert "cannot be used on a class" in str(excinfo.value)
-
 
 @pytest.mark.asyncio
 async def test_deploy_disconnect(servicer, client):