Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bumping codecov-action to v4 #422

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Sep 20, 2023

Dependabot had bumped the codecov action to v4 and it passed CI, but now
it doesn't. I'm guessing there was a mistake where they removed v4. At
the time of this PR there are v4-beta tags.

Dependabot had bumped the codecov action to v4 and it passed CI, but now
it doesn't. I'm guessing there was a mistake where they removed v4. At
the time of this PR there are v4-beta tags.
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Sep 20, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/XS PRs with less than 30 lines of changes label Sep 20, 2023
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Sep 20, 2023
@meowblecoinbot meowblecoinbot requested a review from a team September 20, 2023 21:23
@nick-mobilecoin
Copy link
Collaborator Author

PR that bumped to v4, #420
The action that ran v4, https://github.com/mobilecoinfoundation/sgx/actions/runs/6189584117/job/16804001977

@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team September 20, 2023 21:25
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #422 (5a926a2) into main (1bcf459) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files          40       40           
  Lines        5643     5643           
=======================================
  Hits         4988     4988           
  Misses        655      655           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin merged commit 14c59a6 into main Sep 21, 2023
29 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/fix-coverage branch September 21, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/XS PRs with less than 30 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants