Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serialize and Deserialize traits to Quote3Error #385

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 31, 2023

The Quote3Error type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.

The `Quote3Error` type is used to go to/from an enclave from the
untrusted application, so it needs to support serialization.
@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@meowblecoinbot meowblecoinbot requested a review from a team July 31, 2023 15:56
@github-actions github-actions bot added the size/S PRs with less than 100 lines of changes label Jul 31, 2023
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 31, 2023 15:59
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #385 (8ef0a24) into main (76506f6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   88.30%   88.33%   +0.02%     
==========================================
  Files          40       40              
  Lines        5627     5639      +12     
==========================================
+ Hits         4969     4981      +12     
  Misses        658      658              
Files Changed Coverage Δ
dcap/types/src/error.rs 98.61% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin merged commit 6ba8412 into main Jul 31, 2023
24 of 25 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/serialize-quote3-error branch July 31, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PRs with less than 100 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants