Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fog-view: Limit number of user events, and tell client this happened #3151

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Feb 19, 2023

  1. fog-view: Limit number of user events, and tell client this happened

    Jason reported recently that fog test client failed in test-net with
    a grpc maximum response size error. Eventually it recovered and I'm
    not sure we fully determined the root cause.
    
    One defect that we noticed during investigation is that, while the
    client limits the number of ETxOutRecord's it requests, nothing limits
    the number of user events that fog view returns -- if the client
    starts from scratch, it always returns all the events.
    
    This patch is meant to fix that. The SQL query is changed so that
    there is a limit to how many user events it returns, and it is ordered
    ascending by the user event id. This limit is configurable as a server
    startup parameter. When the limit is reached, we flag to the client
    that there may be more user events.
    
    Then we update the `fog-view-protocol` polling module so that when
    this flag is set, it keeps asking for more seeds until this flag
    isn't set any more.
    
    I believe that this is a backwards compatible change, because old
    clients will ignore this flag, and for new clients talking to old
    servers, this flag will have a default value of false, which matches
    the status quo behavior of always returning all the results.
    cbeck88 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    28bf64f View commit details
    Browse the repository at this point in the history
  2. add a change log entry

    cbeck88 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    704734a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Update fog/view/enclave/api/src/lib.rs

    Co-authored-by: Sam Dealy <[email protected]>
    cbeck88 and samdealy authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    22adbdf View commit details
    Browse the repository at this point in the history
  2. Update fog/types/src/view.rs

    Co-authored-by: Sam Dealy <[email protected]>
    cbeck88 and samdealy authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c94da3e View commit details
    Browse the repository at this point in the history
  3. Update fog/api/proto/view.proto

    Co-authored-by: Sam Dealy <[email protected]>
    cbeck88 and samdealy authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    64f407d View commit details
    Browse the repository at this point in the history