Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/json_test.c: toctou race condition #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b4yuan
Copy link

@b4yuan b4yuan commented Jul 1, 2023

Separately checking the state of a file before operating on it may allow an attacker to modify the file between the two operations.

perror(path);

if (S_ISDIR(sb.st_mode)) {
fprintf(stderr, "Skipping directory '%s'\n", path);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to call fclose(fh) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants