-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Validate inputs with pydantic #779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already found either a usage error or documentation / type-hinting error:
Changing to just be |
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#780)
Very nice otherwise!! |
agramfort
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
I don’t remember. Probably it fixed something with some version of MNE. You
can remove it or keep it and we see what happens :)
…On Tue, 15 Aug 2023 at 19:10, Eric Larson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In mne_bids_pipeline/tests/configs/config_ERP_CORE.py
<#779 (comment)>
:
> @@ -50,7 +49,7 @@
# Suppress "Data file name in EEG.data (sub-019_task-ERN_eeg.fdt) is incorrect..."
read_raw_bids_verbose = "error"
-eeg_template_montage = mne.channels.make_standard_montage("standard_1005")
+eeg_template_montage = "standard_1005"
Ahh, doing a bit of git digging I can see #407
<#407> by @dengemann
<https://github.com/dengemann> so it was indeed intentional... I'll add
support back in
—
Reply to this email directly, view it on GitHub
<#779 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOR7CTKCTHOMVSMSRGUID3XVOURBANCNFSM6AAAAAA3QGKJGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
pydantic
after adding as a dependency (2.0 seems to be the min useable version for us based on local testing)decoding_csp_times
anddecoding_csp_freqs
didn't do what we said they did (they were set once statically based on the defaults rather than being computed dynamically based on the variable values)docs/source/changes.md
)Locally it seems to work -- adding
config_validation = "foo"
toconfig_ds003392.py
for example produces:or when setting
mf_destination = "foo"
inconfig_ds003392.py
which allows a specific Literal or a FloatArrayLike:Because of the
strict=True
I suspect there will be someList
s that we will want to change toFloatArrayLike
(or create a genericCheckedArrayLike
that allows arbitrary dtypes or something) but this is maybe a good enough start!Closes #766