Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Change default to _cache #778

Merged
merged 1 commit into from
Aug 14, 2023
Merged

API: Change default to _cache #778

merged 1 commit into from
Aug 14, 2023

Conversation

larsoner
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)

Closes #723

@hoechenberger feel free to mark as merge-when-green if you're happy.

@hoechenberger
Copy link
Member

@larsoner Any particular reason not to call it .cache?

@larsoner
Copy link
Member Author

@larsoner Any particular reason not to call it .cache?

From the discussion in the linked issue #723 (comment) it seemed like .cache was no good / unsafe but _cache was okay

@larsoner larsoner merged commit 918cc3b into mne-tools:main Aug 14, 2023
7 checks passed
@larsoner larsoner deleted the joblib branch August 14, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"joblib" directory in output folder
2 participants