Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deriv_root argument to CLI #773

Merged
merged 11 commits into from
Aug 7, 2023
Merged

Added deriv_root argument to CLI #773

merged 11 commits into from
Aug 7, 2023

Conversation

vferat
Copy link
Contributor

@vferat vferat commented Aug 7, 2023

Closes #772.

I do not see unit test and/or test for other cli arguments, so I didn't implemented any for the current changes. Let me know if you think it is necessary.

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@welcome
Copy link

welcome bot commented Aug 7, 2023

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

mne_bids_pipeline/_config.py Outdated Show resolved Hide resolved
mne_bids_pipeline/_config.py Outdated Show resolved Hide resolved
@larsoner
Copy link
Member

larsoner commented Aug 7, 2023

Argh I enabled pre-commit.ci and it pushed something it shouldn't have... Feel free to keep working on this and don't worry about freesurfer code changes. I'll fix those in a separate PR then push a revert commit here. We squash history when merging later anyway so it should be okay :)

mne_bids_pipeline/_main.py Outdated Show resolved Hide resolved
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vferat feel free to un-mark as draft or just let me know if you're done in a comment and I'll mark for merge-when green (assuming the feature works for you now)!

@vferat vferat marked this pull request as ready for review August 7, 2023 14:34
docs/source/v1.5.md.inc Outdated Show resolved Hide resolved
mne_bids_pipeline/_main.py Outdated Show resolved Hide resolved
Co-authored-by: Richard Höchenberger <[email protected]>
@larsoner larsoner enabled auto-merge (squash) August 7, 2023 16:31
@larsoner larsoner merged commit 721e728 into mne-tools:main Aug 7, 2023
7 checks passed
@welcome
Copy link

welcome bot commented Aug 7, 2023

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command line option for deriv_root
3 participants