Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deep-cloning for LearnerTorch and friends #198

Merged
merged 16 commits into from
Jun 14, 2024
Merged

fix: deep-cloning for LearnerTorch and friends #198

merged 16 commits into from
Jun 14, 2024

Conversation

sebffischer
Copy link
Member

@sebffischer sebffischer commented Feb 8, 2024 •
edited
Loading

depends on: mlverse/torch#1134

  • Ensure that the parameters that the optimizer points to are those of the network after cloning we only store the optimizer state dict
  • run expect deep clone on learner torch
  • hashes are correct

@sebffischer sebffischer marked this pull request as draft February 8, 2024 14:21
@sebffischer sebffischer changed the title WIP fix: deep-cloning for LearnerTorch and friends Feb 8, 2024
@sebffischer sebffischer mentioned this pull request Feb 8, 2024
Closed
2 tasks
@sebffischer sebffischer marked this pull request as ready for review June 14, 2024 07:44
@sebffischer sebffischer merged commit d41d116 into main Jun 14, 2024
5 checks passed
@sebffischer sebffischer deleted the fix/deep-cloning branch June 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebffischer