Fix Lumen compatibility (#23)

mll-lab · Jun 19, 2023 · 16f19ce · 16f19ce
1 parent 43eb17b
commit 16f19ce
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@ See [GitHub releases](https://github.com/mll-lab/laravel-graphiql/releases).
 
 ## Unreleased
 
+## v3.0.1
+
+### Fixed
+
+- Fix Lumen compatibility
+
 ## v3.0.0
 
 ### Removed

diff --git a/src/DownloadAssetsCommand.php b/src/DownloadAssetsCommand.php
@@ -53,7 +53,7 @@ protected function downloadFileFromCDN(string $localPath, string $cdnPath): void
         }
 
         $contents = file_get_contents("https:{$cdnPath}");
-        if (false === $contents) {
+        if ($contents === false) {
             $error = error_get_last();
             throw new \ErrorException($error['message'] ?? 'An error occurred', 0, $error['type'] ?? 1);
         }

diff --git a/src/GraphiQLController.php b/src/GraphiQLController.php
@@ -3,7 +3,6 @@
 namespace MLL\GraphiQL;
 
 use Illuminate\Config\Repository as ConfigRepository;
-use Illuminate\Contracts\Routing\UrlGenerator;
 use Illuminate\Contracts\View\Factory as ViewFactory;
 use Illuminate\Contracts\View\View;
 use Illuminate\Http\Request;
@@ -12,7 +11,6 @@
 class GraphiQLController
 {
     public function __construct(
-        protected UrlGenerator $urlGenerator,
         protected ViewFactory $viewFactory,
     ) {}
 
@@ -34,7 +32,7 @@ public function __invoke(ConfigRepository $config, Request $request): View
     protected function maybeURL(?string $endpoint): ?string
     {
         return is_string($endpoint) && filter_var($endpoint, FILTER_VALIDATE_URL)
-            ? $this->urlGenerator->to($endpoint)
+            ? url($endpoint) // Avoid injecting UrlGenerator for Lumen compatibility
             : $endpoint;
     }
 }